[Differential] [Request, 4 lines] D1532: validate the config before checking if it can be applied
sebas (Sebastian Kügler)
noreply at phabricator.kde.org
Wed May 4 02:14:52 UTC 2016
sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
canBeApplied is public API, it shouldn't blow up when passed an invalid
config, but indicate (correctly!) that this "config" can't be applied.
This is called a bit carelessly from the kded daemon. I've fixed it
there as well, but it seems prudent to also make sure in libkscreen that
the user doesn't do stupid things.
CCBUG:362586
TEST PLAN
autotests pass
REPOSITORY
rLIBKSCREEN KScreen Library
BRANCH
sebas/guardcanbeapplied
REVISION DETAIL
https://phabricator.kde.org/D1532
AFFECTED FILES
src/config.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160504/9dd43f01/attachment.html>
More information about the Plasma-devel
mailing list