Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127702/#review95128
-----------------------------------------------------------




autotests/configmodeltest.cpp (line 26)
<https://git.reviewboard.kde.org/r/127702/#comment64562>

    could it be added another test on another (fake) applet that has the full main.xml and config.qml infrastructure to check keys are created correctly?


- Marco Martin


On May 3, 2016, 7:04 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127702/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 7:04 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source property will be empty for KCM pages.
> This fixes correctly returning empty source for KCM pages. Also return the same value from get().
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 747e8e0 
>   autotests/configmodeltest.h PRE-CREATION 
>   autotests/configmodeltest.cpp PRE-CREATION 
>   autotests/data/testpackage/metadata.desktop 2a28849 
>   src/plasmaquick/configmodel.cpp 3f69073 
> 
> Diff: https://git.reviewboard.kde.org/r/127702/diff/
> 
> 
> Testing
> -------
> 
> Added qml config page to plasma-pa, KCM page now works fine.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160503/8b05f59d/attachment.html>