Review Request 127487: Fix bindings in KCM MuteButton

Sebastian Kügler sebas at kde.org
Thu Mar 31 20:23:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127487/#review94161
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Kügler


On March 24, 2016, 8:37 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127487/
> -----------------------------------------------------------
> 
> (Updated March 24, 2016, 8:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Assigning value to muted property clears the binding.
> 
> 
> Diffs
> -----
> 
>   src/kcm/package/contents/ui/DeviceListItem.qml 979c693 
>   src/kcm/package/contents/ui/MuteButton.qml 693ab2d 
>   src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/127487/diff/
> 
> 
> Testing
> -------
> 
> Click mute -> unmute the device from other app -> mute button have correct state
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160331/9e7f4a4c/attachment.html>


More information about the Plasma-devel mailing list