Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

Martin Klapetek martin.klapetek at gmail.com
Thu Mar 31 02:54:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127455/
-----------------------------------------------------------

(Updated March 30, 2016, 7:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin Klapetek to branch master.


Bugs: 360683
    http://bugs.kde.org/show_bug.cgi?id=360683


Repository: plasma-framework


Description
-------

This removes some old cruft that is not really used and serves
basically only as a bool property for checking if it's null and
wheter it equals the last activated date.

This can be done without it by simply resetting the current selected
date (another property) to "today".

I decided to leave the useless property in for the time being
to allow for some buffer time between the -workspace and -framework
release so that it does not throw errors (ie. if distros will
ship 5.6 + p-f 5.21).


Diffs
-----

  src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f 
  src/declarativeimports/calendar/qml/MonthView.qml 76c605a 

Diff: https://git.reviewboard.kde.org/r/127455/diff/


Testing
-------

Selection is properly cleared.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160331/8a0e489a/attachment-0001.html>


More information about the Plasma-devel mailing list