Review Request 126630: Do not unconditionally enable logging

[Peter Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126630/
-----------------------------------------------------------

(Updated March 29, 2016, 6:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Solid, Daniel Vrátil, and Sebastian Kügler.


Changes
-------

Submitted with commit 649dda5e8c8f683f1650b4cf609fe094d22e3290 by Albert Astals Cid on behalf of Peter Wu to branch Plasma/5.6.


Repository: libkscreen


Description
-------

Logging is [enabled by default][1], there is no read to use setFilterRules
and [override][2] any user preferences in QtProject/qtlogging.ini.

Keep unconditional logging enabled for the fake backend though, this
ensures that unit tests have log messages even if the user disabled all
other debug messages.

 [1]: https://doc.qt.io/qt-5/qloggingcategory.html#Q_LOGGING_CATEGORY
 [2]: https://doc.qt.io/qt-5/qloggingcategory.html#configuring-categories


Diffs
-----

  backends/kwayland/waylandbackend.cpp 0700e22 
  backends/qscreen/qscreenbackend.cpp 56b5a7c 
  backends/xcbeventlistener.cpp ee415d7 
  backends/xrandr/xrandr.cpp fae1dcc 
  backends/xrandr1.1/xrandr11.cpp 631bcc9 
  src/debug_p.cpp 5934417 

Diff: https://git.reviewboard.kde.org/r/126630/diff/


Testing
-------

Tested on v5.5.2 (cherry-picked, ignored missing backends/kwayland/waylandbackend.cpp).

Test:

 1. Have no kscreen related lines in ~/.config/QtProject/qtlogging.ini
 2. killall kscreen_backend_launcher
 3. Change brightness levels via the keyboard. (Result: `RRNotify_OutputProperty` messages in `journalctl`)
 4. Add the following lines to qtlogging.ini:
```
kscreen.debug=false
kscreen.xrandr.debug=false
kscreen.xcb.helper.debug=false
```
 5. killall kscreen_backend_launcher
 6. Change brightness levels again. (Result: no log spam!)


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160329/c9933cdc/attachment.html>