Review Request 125862: Add simple calendar events plugin based on KHolidays

Martin Klapetek martin.klapetek at gmail.com
Mon Mar 28 19:54:26 UTC 2016



> On Feb. 23, 2016, 2:09 p.m., David Edmundson wrote:
> > Martin, what is the state of this?
> > 
> > You're in danger of missing Plasma 5.6.
> 
> Martin Klapetek wrote:
>     I very likely won't be able to finish it in this cycle.
> 
> David Edmundson wrote:
>     well, what's missing?
>     I don't want to miss 5.7 too.

It’s on my todo once I'm back from vacation.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review92660
-----------------------------------------------------------


On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 1:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> -------
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160328/f4b64b2f/attachment-0001.html>


More information about the Plasma-devel mailing list