Review Request 127512: Fix memory leak in Kicker

David Edmundson david at davidedmundson.co.uk
Mon Mar 28 02:46:14 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127512/#review94055
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On March 28, 2016, 12:11 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127512/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 12:11 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Found by coverity, seems we forgot to delete m_fileItem and I can't see other way it would be freed.
> 
> 
> Diffs
> -----
> 
>   applets/kicker/plugin/fileentry.h 4c67e79 
>   applets/kicker/plugin/fileentry.cpp 9c978fa 
> 
> Diff: https://git.reviewboard.kde.org/r/127512/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160328/3840989d/attachment.html>


More information about the Plasma-devel mailing list