Review Request 127499: [showdesktop] Fix sizing of the plasmoid in the panel

Kai Uwe Broulik kde at privat.broulik.de
Sat Mar 26 13:47:05 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127499/#review94024
-----------------------------------------------------------


Ship it!




Ship It!

- Kai Uwe Broulik


On März 26, 2016, 1:34 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127499/
> -----------------------------------------------------------
> 
> (Updated März 26, 2016, 1:34 nachm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Since 5.6, if you add a "Show Desktop" plasmoid to the panel, the panel's layout gets completely broken (apparently the plasmoid is sized to infinity).
> This sets the minimum size to sane values which fixes the problem.
> 
> (Note that this is for the 5.6 branch only, the problem doesn't exist in master)
> 
> 
> Diffs
> -----
> 
>   applets/showdesktop/package/contents/ui/main.qml 2117dd5 
> 
> Diff: https://git.reviewboard.kde.org/r/127499/diff/
> 
> 
> Testing
> -------
> 
> Add a "Show Desktop" plasmoid to the panel, it works as expected now.
> And it still works on the desktop too.
> 
> 
> File Attachments
> ----------------
> 
> Panel in 5.6.0 after adding "Show Desktop"
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/26/a889bb57-6b7a-4b28-92cb-85edb359003c__before.png
> Same panel after adding this patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/26/98a734d1-ca67-4905-8137-9ed5c7dca11c__after.png
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160326/99b58851/attachment-0001.html>


More information about the Plasma-devel mailing list