Review Request 127494: Fix drawing correct focus state of QtQuickControls Button
Hugo Pereira Da Costa
hugo.pereira at free.fr
Sat Mar 26 10:47:09 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127494/#review94018
-----------------------------------------------------------
Ship it!
This makes sense, and is cleaner.
We'll see later if this breaks other things.
- Hugo Pereira Da Costa
On March 26, 2016, 10:41 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127494/
> -----------------------------------------------------------
>
> (Updated March 26, 2016, 10:41 a.m.)
>
>
> Review request for Plasma and Hugo Pereira Da Costa.
>
>
> Repository: breeze
>
>
> Description
> -------
>
> Button with checked == true would be incorrectly drawn as always having focus.
> Checked QtQuickControls Button always have State_Sunken.
>
>
> Diffs
> -----
>
> kstyle/breezestyle.cpp e97ead6
>
> Diff: https://git.reviewboard.kde.org/r/127494/diff/
>
>
> Testing
> -------
>
> Fixed for QQC, no change in QtWidgets.
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160326/19caa88a/attachment.html>
More information about the Plasma-devel
mailing list