Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127494/#review94012
-----------------------------------------------------------




kstyle/breezestyle.cpp (line 3388)
<https://git.reviewboard.kde.org/r/127494/#comment64019>

    mmm. But is it not rather a qtc bug that states are set in an inconsistent manner between widgets and qtc ? 
    This is not the only place in breeze where we have to work around these kind of issues (the other being min iconsize in menus to cite one)
    This just tend to make the breeze code bloated and hard to maintain. Besides it doesn't fix the "other" styles (there is oxygen, but there are others). 
    What are the chances to get these fixed upstream (eg: sunken !? checked) ?


- Hugo Pereira Da Costa


On March 25, 2016, 8:26 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127494/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 8:26 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Button with checked == true would be incorrectly drawn as always having focus.
> Checked QtQuickControls Button always have State_Sunken.
> 
> 
> Diffs
> -----
> 
>   kstyle/breezestyle.cpp e97ead6 
> 
> Diff: https://git.reviewboard.kde.org/r/127494/diff/
> 
> 
> Testing
> -------
> 
> Fixed for QQC, no change in QtWidgets.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160326/c6f62858/attachment.html>