Review Request 127498: Cleanup warnings

David Rosca nowrep at gmail.com
Sat Mar 26 09:07:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127498/
-----------------------------------------------------------

(Updated March 26, 2016, 9:07 a.m.)


Review request for Plasma.


Changes
-------

Fix logic for volume changes - pa_cvolume_equal only compares pointers


Repository: plasma-pa


Description
-------

Change some warnings to todo/fixme and fix the others.

VolumeObject::volumeChanged is now emitted only when the volume actually changes.
Unavailable card profiles are no longer listed when built with PulseAudio >= 5.0.


Diffs (updated)
-----

  src/card.cpp 2e251a7 
  src/context.cpp 115c8a7 
  src/pulseaudio.cpp 1488784 
  src/volumeobject.h c64a964 

Diff: https://git.reviewboard.kde.org/r/127498/diff/


Testing
-------


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160326/c8d213c1/attachment-0001.html>


More information about the Plasma-devel mailing list