Review Request 127492: KCM: Add possibility to move stream to other devices
David Rosca
nowrep at gmail.com
Fri Mar 25 13:45:46 UTC 2016
> On March 25, 2016, 1:41 p.m., Kai Uwe Broulik wrote:
> > While I like seeing this option return, especially with your other "Primary Device" patch makes this UI really cluttered.
> >
> > What about having a drop down button with the device icon rather than the full-blown text in there? So you'll at least be able to tell at a glance "it's on my headset" or so
Primary Device is only for Devices, not Streams.
Device icons are too generic (not to mention that currently every device have the same icons, needs to be fixed). If you have more cards (eg. internal + usb) you wouldn't be able to tell them apart, only headset will have different icon.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127492/#review93977
-----------------------------------------------------------
On March 25, 2016, 1:34 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127492/
> -----------------------------------------------------------
>
> (Updated March 25, 2016, 1:34 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> Add combobox next to mute button with available devices.
>
>
> Diffs
> -----
>
> src/kcm/package/contents/ui/SinkInputView.qml PRE-CREATION
> src/kcm/package/contents/ui/SourceOutputView.qml PRE-CREATION
> src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e
> src/kcm/package/contents/ui/StreamView.qml b08c87a
> src/kcm/package/contents/ui/main.qml 3360201
>
> Diff: https://git.reviewboard.kde.org/r/127492/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot_20160325_142736.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160325/e8e1c579/attachment.html>
More information about the Plasma-devel
mailing list