Review Request 127467: PulseClient: Implement heuristics to find icon for stream
David Rosca
nowrep at gmail.com
Fri Mar 25 13:39:56 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127467/
-----------------------------------------------------------
(Updated March 25, 2016, 1:39 p.m.)
Review request for Plasma.
Changes
-------
Remove hardcoded icon names
Repository: plasma-pa
Description
-------
Implement heuristics searching for icon in desktop files.
Also try stream name to find icon if everything else fails.
Diffs (updated)
-----
CMakeLists.txt 3a0f690
src/CMakeLists.txt b3e1855
src/client.h 3b9050e
src/client.cpp 6fc5814
src/qml/ClientIcon.qml 83545a1
Diff: https://git.reviewboard.kde.org/r/127467/diff/
Testing
-------
Streams now have icons even when icon_name or binary properites are empty.
Thanks,
David Rosca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160325/71a34a73/attachment-0001.html>
More information about the Plasma-devel
mailing list