Review Request 127485: KCM: Add button to set default devices

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127485/
-----------------------------------------------------------

(Updated March 24, 2016, 9:08 p.m.)


Review request for Plasma and KDE Usability.


Changes
-------

Use RadioButton


Repository: plasma-pa


Description
-------

It is now possible to set default input and output devices.
UI is exactly the same as pavucontrol - checkable button next to mute button.


Diffs (updated)
-----

  src/CMakeLists.txt b3e1855 
  src/context.h 8a3a821 
  src/context.cpp 115c8a7 
  src/device.h 5867fb2 
  src/kcm/package/contents/ui/DefaultDeviceButton.qml PRE-CREATION 
  src/kcm/package/contents/ui/DeviceListItem.qml 979c693 
  src/server.h PRE-CREATION 
  src/server.cpp PRE-CREATION 
  src/sink.h 7db716b 
  src/sink.cpp d412b7b 
  src/source.h 325cde9 
  src/source.cpp fa9f0a0 

Diff: https://git.reviewboard.kde.org/r/127485/diff/


Testing
-------

Works same as pavucontrol. pavucontrol uses "emblem-default" as icon, but this icon is not in Breeze so I used "checkmark". Unfortunately it isn't entirely clear what the button is doing from the icon ...


File Attachments (updated)
----------------

kcm-default-device.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/6d5d5bb5-3619-470c-b6d6-e7693d888c9b__kcm-default-device.png
kcm-default-device.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/23f3638a-aa27-4f46-aa6a-989c8d313a6a__Screenshot_20160324_220624.png


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160324/e8e5c671/attachment.html>