Review Request 127476: [Volume item] Increase / decrease by wheel

[David Rosca]

> On March 24, 2016, 6:25 a.m., David Rosca wrote:
> > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against blocking it, but there is a valid reason for it.
> > 
> > Also, I think you can just remove the MouseArea (as Slider allows to change value with mouse wheel by default) instead of reimplementing the logic.
> 
> Anthony Fieroni wrote:
>     I'm not removing MouseArea to not fooling the updateTimer, if it can happen. Actual volume is changed in applet and kcm, current code of src/kcm/package/contents/ui/VolumeSlider.qml is without MouseArea, i can remove it.
>     Same code on 2 side => horrible nightmare
> 
> David Rosca wrote:
>     What's the problem with updateTimer? The code should be identical with KCM, except there is a MouseArea that blocks wheel events in applet. So if it doesn't work, it should be fixed there too.
>     
>     Regarding the wheel blocking, I think we should instead of blocking wheel on sliders block wheel to scroll view when mouse is on/above/below slider - enable scrolling only when mouse is on the sides (on the volume icon on the left and percent label on the right). That way we have wheel changing volume on sliders, don't have accidental volume change when scrolling but still are able to scroll the view on the sides.
> 
> Anthony Fieroni wrote:
>     1. updateTimer can run and wheel may change position who reflect on onValueChanged and logic can go down, easly. About me this patch is needed for kcm too, i may wrong. :)
>     2. I test, mouse wheel is only on wiew item.
> 
> David Rosca wrote:
>     Can you please elaborate? It shouldn't matter if updateTimer is running, as wheel event will result in valueChanged and that will restart the timer. I'm not saying there is not an issue, right now I managed to end in infinite loop when messing with slider (can't reproduce it again...), but I'd like to understand it.
> 
> Anthony Fieroni wrote:
>     I'll remove MouseArea and rewrite timer logic, it seems wrong. I think we must set volume and wait for feedback (pulse can ignore it)

Currently it changes the slider value instantly and then sync the value with pulse after 200msecs, so it does handle the case when pulse ignores the change.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127476/#review93911
-----------------------------------------------------------


On March 23, 2016, 5:43 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127476/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 5:43 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> I don't know why it's disabled, it's pretty handy
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 2e31eeb 
> 
> Diff: https://git.reviewboard.kde.org/r/127476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160324/e37f6655/attachment.html>