Review Request 127460: Fix drawing QtQuickControls ComboBox popups

David Rosca nowrep at gmail.com
Tue Mar 22 15:25:25 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/
-----------------------------------------------------------

(Updated March 22, 2016, 4:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Hugo Pereira Da Costa.


Changes
-------

Submitted with commit c2008d6d3a62b3f7f6e5198e047d39b4a40ecf7e by David Rosca to branch Plasma/5.6.


Bugs: 343369
    https://bugs.kde.org/show_bug.cgi?id=343369


Repository: breeze


Description
-------

Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
Also expand CT_ItemViewItem size for QtQuickControls too.

BUG: 343369


Diffs
-----

  kstyle/breezestyle.cpp 9a4b674 

Diff: https://git.reviewboard.kde.org/r/127460/diff/


Testing
-------

QtQuickControls ComboBox popups now use palette colors and have correct spacing.


File Attachments
----------------

popup-light.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
popup-dark.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160322/b4e66b17/attachment.html>


More information about the Plasma-devel mailing list