Review Request 127460: Fix drawing QtQuickControls ComboBox popups

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93866
-----------------------------------------------------------




kstyle/breezestyle.cpp (line 2905)
<https://git.reviewboard.kde.org/r/127460/#comment63953>

    Nice that it now works.
    
    In the past I had to introduce the isQtQuickControl test here because expanding the size was resulting into buggy item selection ...
    
    This to say: this might create regression against older versions of Qt
    
    ... in fact: this change is somewhat unrelated to the second fix (which is more critical)
    I would put it in a separate commit, in case it needs revert.



kstyle/breezestyle.cpp (line 5059)
<https://git.reviewboard.kde.org/r/127460/#comment63952>

    For clarity I would rather put it the other way around:
    
    if( isQtQuickControl())
    {
      
      ...
      return true;
      
    } else return false;


- Hugo Pereira Da Costa


On March 22, 2016, 2:35 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 2:35 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
>     https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -----
> 
>   kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> -------
> 
> QtQuickControls ComboBox popups now use palette colors and have correct spacing.
> 
> 
> File Attachments
> ----------------
> 
> popup-light.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
> popup-dark.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160322/050ace32/attachment.html>