Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

[Martin Klapetek]

> On March 21, 2016, 10:25 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, lines 36-37
> > <https://git.reviewboard.kde.org/r/127455/diff/1/?file=453733#file453733line36>
> >
> >     While I agree, this property is stupid, it would break our API-compatibility promise.

Which is why I kept it in ;) I can replace the comment though that this is useless.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127455/#review93841
-----------------------------------------------------------


On March 21, 2016, 10:11 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127455/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 10:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 360683
>     http://bugs.kde.org/show_bug.cgi?id=360683
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This removes some old cruft that is not really used and serves
> basically only as a bool property for checking if it's null and
> wheter it equals the last activated date.
> 
> This can be done without it by simply resetting the current selected
> date (another property) to "today".
> 
> I decided to leave the useless property in for the time being
> to allow for some buffer time between the -workspace and -framework
> release so that it does not throw errors (ie. if distros will
> ship 5.6 + p-f 5.21).
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f 
>   src/declarativeimports/calendar/qml/MonthView.qml 76c605a 
> 
> Diff: https://git.reviewboard.kde.org/r/127455/diff/
> 
> 
> Testing
> -------
> 
> Selection is properly cleared.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160321/f62de66f/attachment.html>