Review Request 127442: Fixing the force-create for the applet creation
Marco Martin
notmart at gmail.com
Sun Mar 20 21:39:45 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127442/#review93802
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On March 20, 2016, 9:19 p.m., Ivan Čukić wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127442/
> -----------------------------------------------------------
>
> (Updated March 20, 2016, 9:19 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> The new system tray does not work on locked plasma because the force-create does not work properly for applet creation.
>
> The code that did the force-create for containments is ok, but for applet creation, there are two places where the mutability check is performed, and only one was bypassed with the force-create flag.
>
>
> Diffs
> -----
>
> src/plasma/applet.cpp 473e7a6
> src/plasma/containment.cpp 84a1301
>
> Diff: https://git.reviewboard.kde.org/r/127442/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan Čukić
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160320/9c687daa/attachment.html>
More information about the Plasma-devel
mailing list