Review Request 127427: [Fading Node] Don't mix opacity separately

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127427/#review93739
-----------------------------------------------------------


Ship it!




Seems weird that I took a longer more incorrect route in the first place.

but yours works better, Ship it!

- David Edmundson


On March 19, 2016, 4:33 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127427/
> -----------------------------------------------------------
> 
> (Updated March 19, 2016, 4:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355894
>     http://bugs.kde.org/show_bug.cgi?id=355894
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This breaks icon item fading when opacity is < 1 as can be observed in ksmserver's logout dialog
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/fadingnode.cpp 64bf3ec 
> 
> Diff: https://git.reviewboard.kde.org/r/127427/diff/
> 
> 
> Testing
> -------
> 
> Works fine now, tests still pass, verified that it doesn't flicker anymore:
> 
> PlasmaCore.IconItem {
>     width: 200; height: 200
>     active: mouse.containsMouse
>     source: "folder-home"
>     opacity: 0.5
>     
>     MouseArea {
>         id: mouse
>         anchors.fill: parent
>         hoverEnabled: true
>     }
> }
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160319/ce80ffe7/attachment.html>