Review Request 127426: [Svg] Don't reparse configuration in response to Theme::applicationPaletteChanged

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127426/#review93721
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On March 19, 2016, 3:29 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127426/
> -----------------------------------------------------------
> 
> (Updated March 19, 2016, 3:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Plasma::Theme emits the applicationPaletteChange signal only after it has already fetched the colors form KColorScheme and scheduled the caches to be nuked.
> 
> Avoids reparsing it a hundred times in all the SVGs.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.cpp 943d3af 
>   src/plasma/svg.cpp ccd248a 
> 
> Diff: https://git.reviewboard.kde.org/r/127426/diff/
> 
> 
> Testing
> -------
> 
> Changing colors in System Settings is now on-par with the opened applications performance-wise; previously Plasma froze for 10s of seconds.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160319/0949b021/attachment.html>