Review Request 127426: [Svg] Don't reparse configuration in response to Theme::applicationPaletteChanged
Kai Uwe Broulik
kde at privat.broulik.de
Sat Mar 19 15:28:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127426/
-----------------------------------------------------------
(Updated März 19, 2016, 3:28 nachm.)
Review request for Plasma.
Repository: plasma-framework
Description
-------
Svg emits the applicationPaletteChange signal only after it has already fetched the colors form KColorScheme and scheduled the caches to be nuked.
Avoids reparsing it a hundred times in all the SVGs.
Diffs
-----
src/plasma/private/theme_p.cpp 943d3af
src/plasma/svg.cpp ccd248a
Diff: https://git.reviewboard.kde.org/r/127426/diff/
Testing (updated)
-------
Changing colors in System Settings is now on-par with the opened applications performance-wise; previously Plasma froze for 10s of seconds.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160319/55f6e776/attachment.html>
More information about the Plasma-devel
mailing list