[Differential] [Commented On] D1168: Split drm_backend.{h,cpp] into separate files

[graesslin (Martin Gräßlin)]

graesslin added a comment.


  Thanks for doing the split!

INLINE COMMENTS
  backends/drm/drm_backend.cpp:50-52 please remove if no longer needed
  backends/drm/drm_backend.h:55-57 why are the forward declarations removed? If that compiled before the split with forward declarations instead of includes that should still be possible
  backends/drm/drm_buffer.cpp:20-21 Krazy would tell you to include own header first
  backends/drm/drm_buffer.cpp:24 I don't see this one used
  backends/drm/drm_buffer.cpp:25-27 I don't see this one used
  backends/drm/drm_inputeventfilter.h:25 I don't see QPointer used her
  backends/drm/drm_inputeventfilter.h:26 I don't see any QSize in this file
  backends/drm/drm_output.cpp:274-275 Please don't push your local TODO commits
  backends/drm/drm_output.cpp:597-599 similar
  backends/drm/drm_pointer.h:23 no QPointer in this file, though I see a QScopedPointer
  backends/drm/scene_qpainter_drm_backend.cpp:53-58 unrelated to the split

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160318/fc290ed2/attachment.html>