Review Request 127417: Fix KDE -> Plasma in keyboard kcm strings

David Edmundson david at davidedmundson.co.uk
Fri Mar 18 01:31:10 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127417/#review93671
-----------------------------------------------------------


Ship it!




It's only relevant in Plasma.

>From the KDED .desktop.

[Desktop Entry]
Type=Service
X-KDE-ServiceTypes=KDEDModule
X-KDE-Library=keyboard
OnlyShowIn=KDE;

Last line means it'll only be loaded automatically on Plasma sessions.

- David Edmundson


On March 18, 2016, 1:28 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127417/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 1:28 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> See the summary.
> 
> I did not commit it directly because I'm not completely sure if the content applies only for Plasma or if there are other cases when kded_keyboard (as it looks like) starts and applies the settings. Can anyone please confirm?
> 
> 
> Diffs
> -----
> 
>   doc/kcontrol/keyboard/index.docbook 813dab4 
>   kcms/keyboard/kcmmiscwidget.ui 3603b96 
> 
> Diff: https://git.reviewboard.kde.org/r/127417/diff/
> 
> 
> Testing
> -------
> 
> It compiles, the modified strings are used.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160318/bebee4ab/attachment.html>


More information about the Plasma-devel mailing list