Review Request 127413: port the interactuive console runner

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127413/#review93670
-----------------------------------------------------------


Fix it, then Ship it!




fix typo in commit message and bonus debug.


runners/plasma-desktop/plasma-desktop-runner.cpp (line 56)
<https://git.reviewboard.kde.org/r/127413/#comment63864>

    !


- David Edmundson


On March 17, 2016, 5:52 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127413/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 5:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> this runner was still unported, and is kinda fundamental as is the only gui-ish way to pop up the interactive console
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 358bd7a 
>   runners/plasma-desktop/CMakeLists.txt 3b81c88 
>   runners/plasma-desktop/plasma-desktop-runner.h 7739bbc 
>   runners/plasma-desktop/plasma-desktop-runner.cpp 7240fb4 
> 
> Diff: https://git.reviewboard.kde.org/r/127413/diff/
> 
> 
> Testing
> -------
> 
> works for both the desktop and kwin modes
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/2afd9a31/attachment-0001.html>