Review Request 127346: Infrastructure for Plasmoid integration testing

[Hrvoje Senjan]

> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote:
> > shell/testcorona.cpp, line 22
> > <https://git.reviewboard.kde.org/r/127346/diff/4/?file=449839#file449839line22>
> >
> >     PlasmaQuick doesn't have any headers installed, so the build fails.
> 
> Aleix Pol Gonzalez wrote:
>     Are you sure? https://paste.kde.org/p7zxnmpr2
> 
> Hrvoje Senjan wrote:
>     Well, with KF5.20.0 they aren't installed here (cmake 3.4.3).
>     I see that somehow with master (and cmake 3.3.1) they are.
>     Anyhow with master, the error (plasma-framework bug) is
>     ```
>     [  191s] In file included from /usr/include/KF5/PlasmaQuick/AppletQuickItem:1:0,
>     [  191s]                  from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.5.90git~20160316T165610~e7f09ba/shell/coronatesthelper.cpp:22:
>     [  191s] /usr/include/KF5/plasmaquick/appletquickitem.h:31:32: fatal error: plasmaquick_export.h: No such file or directory
>     [  191s] compilation terminated.
>     ```
> 
> Aleix Pol Gonzalez wrote:
>     What do you mean? that some cmake versions install some headers and some others don't? It looks to me that there might be an issue with your installation...

Diff between plasma-framework 5.20.0 and master (for src/plasmaquick/CMakeLists.txt)
http://paste.opensuse.org/75789267
So it's not strange, just that i don't see how this is not in tarball


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/#review93604
-----------------------------------------------------------


On March 16, 2016, 12:46 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127346/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 12:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Makes it possible to test how/if a plasmoid behaves correctly on the most similar environment possible to what the user would find on a production system.
> 
> * Loads a plasmoid on a panel and the desktop.
> * Lets it test his own stuff
> * Notifies, when done, if failed.
> 
> There's still more to look into:
> 
> * what objects need to be passed, besides the `Plasma::AppletQuickItem`.
> * good things to test
> * how to test other shells than the desktop shell
> 
> Nevertheless, it looks to me that it's a step forward. Comments welcome.
> 
> 
> Diffs
> -----
> 
>   applets/analog-clock/contents/tests/test.qml PRE-CREATION 
>   shell/CMakeLists.txt e553133 
>   shell/main.cpp d6e3640 
>   shell/shellcorona.cpp 54667da 
>   shell/shellmanager.h 17acbc6 
>   shell/shellmanager.cpp 3c3638f 
>   shell/testcorona.h PRE-CREATION 
>   shell/testcorona.cpp PRE-CREATION 
>   shell/tests/CMakeLists.txt PRE-CREATION 
>   shell/tests/testLayout.js.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127346/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/19ef503e/attachment-0001.html>