Review Request 127411: reinrtoduce busy property in Applet

David Edmundson david at davidedmundson.co.uk
Thu Mar 17 16:43:05 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127411/#review93656
-----------------------------------------------------------


Fix it, then Ship it!





src/plasma/applet.h (line 328)
<https://git.reviewboard.kde.org/r/127411/#comment63859>

    typo


- David Edmundson


On March 17, 2016, 4:37 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127411/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 4:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> both the comic and weather applet have to pick out the _plasma_graphicsObject to access the AppletInterface object just to set the busy property on it.
> this reintroduces the busy proeprty in Applet too, both setting it to Applet or AppletInterface will keep them in sync
> 
> 
> Diffs
> -----
> 
>   src/plasma/applet.h c3ab030 
>   src/plasma/applet.cpp 2da9924 
>   src/plasma/private/applet_p.h 312d302 
>   src/plasma/private/applet_p.cpp 14b1deb 
>   src/scriptengines/qml/plasmoid/appletinterface.h 4a186ff 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 941303e 
> 
> Diff: https://git.reviewboard.kde.org/r/127411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/5aaf3f21/attachment.html>


More information about the Plasma-devel mailing list