Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127408/#review93634
-----------------------------------------------------------



Did you also test on Wayland?

- Martin Gräßlin


On March 17, 2016, 3:16 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127408/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 3:16 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> * Remove the initial call to `PanelShadows::self()->addWindow(this);`. It ends up in a winId call that will force a premature construction of the QPlatformWindow.
> * Only update window properties when visible
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp c8c3c71 
> 
> Diff: https://git.reviewboard.kde.org/r/127408/diff/
> 
> 
> Testing
> -------
> 
> I made sure it doesn't end up calling `const_cast<QWindow *>(this)->create();` within `QWindow::winId()`.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/b36f5300/attachment.html>