Review Request 127409: Make sure we're not forcing the window to be created prematurely

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/#review93633
-----------------------------------------------------------



Did you also check that on Wayland? There it is important to have certain things happen before the window is shown, e.g. the role should be set before the window is shown, but the platform window needs to be set already.

Best way might be to completely integrate with the PlatformSurface QEvent and track whether there is a native window. That way we would not need to rely on visible and force creation through winId.

- Martin Gräßlin


On March 17, 2016, 3:13 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127409/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 3:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Only update the properties that require a winId when visible, otherwise let updateVisibility() take care about them.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 7bb63c5 
> 
> Diff: https://git.reviewboard.kde.org/r/127409/diff/
> 
> 
> Testing
> -------
> 
> I don't get platform creations being forced on gdb.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/88fed15f/attachment.html>