Review Request 127408: Remove unneeded shadows setup call
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Mar 17 01:29:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127408/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Remove the initial call to `PanelShadows::self()->addWindow(this);`. It ends up in a winId call that will force a premature construction of the QPlatformWindow.
Diffs
-----
shell/panelview.cpp c8c3c71
Diff: https://git.reviewboard.kde.org/r/127408/diff/
Testing
-------
I made sure it doesn't end up calling `const_cast<QWindow *>(this)->create();` within `QWindow::winId()`.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/04eef5bc/attachment.html>
More information about the Plasma-devel
mailing list