Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

[Aleix Pol Gonzalez]

> On March 13, 2016, 1:54 a.m., David Edmundson wrote:
> > shell/panelview.cpp, line 687
> > <https://git.reviewboard.kde.org/r/125451/diff/3/?file=448826#file448826line687>
> >
> >     This is wrong as you connect to the same signal multiple times.
> >     
> >     this connect should be in the constructor, and we should lose integrateScreen() from showEvent()

I'll move it so it's only connected once. We can't drop the showEvent though, because it's then when we can call winId() for the first time, hence integrateScreen.


> On March 13, 2016, 1:54 a.m., David Edmundson wrote:
> > shell/shellcorona.cpp, line 859
> > <https://git.reviewboard.kde.org/r/125451/diff/3/?file=448828#file448828line859>
> >
> >     you also need this if any one screen size changes not just adding/removing. Which I said in my last review.

That's already the case, reconsiderOutputs is also called when geometries change.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review93459
-----------------------------------------------------------


On March 12, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 6:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Now that everything's in place in Qt, we can do that.
> 
> It basically removes all the translation layer between KScreen and QScreen.
> 
> NOTE: This can't be merged until Qt 5.6 is a dependency.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d407aed 
>   shell/CMakeLists.txt 7be2cfd 
>   shell/panelview.h c671f14 
>   shell/panelview.cpp c8c3c71 
>   shell/shellcorona.h b803239 
>   shell/shellcorona.cpp 54667da 
> 
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
> 
> 
> Testing
> -------
> 
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/823400d6/attachment.html>