Review Request 127352: [kstyle] Implement window shadows on Wayland

Martin Gräßlin mgraesslin at kde.org
Wed Mar 16 08:07:27 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127352/
-----------------------------------------------------------

(Updated March 16, 2016, 9:07 a.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Changes
-------

Implmented the suggestions (except replacing forward declare by include)


Repository: breeze


Description
-------

Integrate with Wayland and create a ShadowManager if available.
With the ShadowManager it's possible to create a Shadow for a Surface.

The Wayland shadow is very similar to the X11 based one, so a lot of
code can be shared. The code is slightly refactored to share the common
code paths to create and destroy the shadow.


Diffs (updated)
-----

  kstyle/CMakeLists.txt b2c6dc847fef1c7876a0ac1af9e28f47422b620b 
  kstyle/breezeshadowhelper.h 0c868d3686eec67e630ce08c36df6b4cf34d7f1c 
  kstyle/breezeshadowhelper.cpp 1eb1ddc6a154d8865b39936718f6a5d5ef8f7fdd 
  kstyle/config-breeze.h.cmake ba2b5f64c1ca855c541fd7eb0e919b8f897f481f 

Diff: https://git.reviewboard.kde.org/r/127352/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160316/bbd0bf4d/attachment.html>


More information about the Plasma-devel mailing list