Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
-----------------------------------------------------------

(Updated March 15, 2016, 5:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Changes
-------

Submitted with commit a79c2be9b4db0755ad6ff6b26a513d71a94ef790 by Anthony Fieroni to branch Plasma/5.6.


Repository: kdeplasma-addons


Description
-------

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs
-----

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/ComicCentralView.qml 59989b2 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
-------

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start working :P


File Attachments
----------------

Screenshot_20160312_214006.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160315/0740e97b/attachment.html>