Review Request 127382: Avoid blocking DBus call to kded
David Edmundson
david at davidedmundson.co.uk
Tue Mar 15 15:22:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/
-----------------------------------------------------------
(Updated March 15, 2016, 4:22 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Jan Grulich.
Changes
-------
Submitted with commit 6d57e1664f1106c3c0fac3a89f5ebc514be01d75 by David Edmundson to branch master.
Repository: plasma-nm
Description
-------
There are two blocking calls here; the QDBusInterface constructor which does introspection and
the init method.
It should be fine to do blocking calls to kded, but given we don't need
to, we may as well avoid them.
Diffs
-----
libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7
libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517
Diff: https://git.reviewboard.kde.org/r/127382/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160315/566e57e2/attachment-0001.html>
More information about the Plasma-devel
mailing list