Review Request 127374: Fix taskbar flicking when opening Plasma popups

[Kai Uwe Broulik]

> On März 14, 2016, 7:10 nachm., Kai Uwe Broulik wrote:
> > Doesn't https://codereview.qt-project.org/#/c/149013/ fix that?
> 
> David Edmundson wrote:
>     Oh wow thanks. I'd just started redoing the same patch. I could have wasted quite some time.
>     
>     David Rosca is super awesome.
>     
>     However, this is still a better way of handling the Qt 5.5 case than what we do currently so I'd still like to merge it.
> 
> Anthony Fieroni wrote:
>     I investigate to see that cause Yakuake stays in taskbar *sometimes*.
> 
> Kai Uwe Broulik wrote:
>     +1 for the patch
>     
>     My comment was more saying "someone already did a Qt patch" but I was too lazy to type that on my phone :)

I was wondering, can't we leverage the surface created event in Qt 5.5, Martin did sth with that in KRunner for flags? Though this is frameworks, so ifdef is probably bad, especially if it's a short-lived thing.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127374/#review93512
-----------------------------------------------------------


On März 14, 2016, 6:45 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127374/
> -----------------------------------------------------------
> 
> (Updated März 14, 2016, 6:45 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When we show a Qt window it resets all wm_states, including the
> SKIP_TASKBAR state that Qt doesn't support see
> QXcbWindow::setNetWmStates
> 
> In order to set the flag we need to do it after Qt has mapped the
> window. (after a showEvent)
> 
> Dialog previously did this using ExposeEvent which we know will happen after show.
> 
> However:
> 1) This is a rather random fix
> 2) It will be called after TaskManager has been notified of a new window
> 
> By merging into the same event we can make sure the flag is set before
> the task manager processes the new window. This means task manager will always skip plasma popups.
> 
> A better fix will obviously be patching Qt to not reset flags it doesn't know about 
> and then we can set this flag in the ctor. I shall try and do that for Qt 5.7.
> 
> BUG: 332024
> REVIEW:
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 56f39c0740a1e32a9588e7461dcb45aab3fe9e85 
> 
> Diff: https://git.reviewboard.kde.org/r/127374/diff/
> 
> 
> Testing
> -------
> 
> Added debug in libtaskmanager, the window flags are always correct for the new window.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160314/7b8b0eb2/attachment.html>