Review Request 127346: RFC: Some infrastructure for Plasma testing

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/#review93425
-----------------------------------------------------------



I quite like it, some comments inline.


shell/main.cpp (line 135)
<https://git.reviewboard.kde.org/r/127346/#comment63687>

    We'll have multiple TestCorona's around if the Shell changes more than once. Not a big deal, since it's only in test mode, just some thing that struck me.



shell/testcorona.cpp (line 70)
<https://git.reviewboard.kde.org/r/127346/#comment63688>

    qCDebug could be useful here



shell/tests/CMakeLists.txt (line 13)
<https://git.reviewboard.kde.org/r/127346/#comment63689>

    I wonder if we should use QTemporaryDir here, but that would mean that we have to set the environment var from the binary. Something to consider, but not critical.



shell/tests/plasma/shells/org.kde.plasmashelltest/contents/layout.js.in (line 12)
<https://git.reviewboard.kde.org/r/127346/#comment63692>

    color wallpaper plugin is more light-weight, using image doesn't add much.



shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml (line 8)
<https://git.reviewboard.kde.org/r/127346/#comment63693>

    whitespace, also on the following line



shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop (line 2)
<https://git.reviewboard.kde.org/r/127346/#comment63691>

    More descriptive descriptive wouldn't hurt :)
    
    Like ... TEST ALL THE THINGS! ;)



shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop (line 3)
<https://git.reviewboard.kde.org/r/127346/#comment63690>

    Encoding is deprecated, defaults to UTF-8 anyway, IIRC.


- Sebastian Kügler


On March 11, 2016, 8:26 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127346/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 8:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Makes it possible to test how/if a plasmoid behaves correctly on the most similar environment possible to what the user would find on a production system.
> 
> * Loads a plasmoid on a panel and the desktop.
> * Lets it test his own stuff
> * Notifies, when done, if failed.
> 
> There's still more to look into:
> * what objects need to be passed, besides the `Plasma::AppletQuickItem`.
> * good things to test
> * how to test other shells than the desktop shell
> 
> Nevertheless, it looks to me that it's a step forward. Comments welcome.
> 
> 
> Diffs
> -----
> 
>   applets/analog-clock/contents/tests/testmain.qml PRE-CREATION 
>   shell/CMakeLists.txt e553133 
>   shell/main.cpp d6e3640 
>   shell/shellmanager.h 17acbc6 
>   shell/shellmanager.cpp 3c3638f 
>   shell/testcorona.h PRE-CREATION 
>   shell/testcorona.cpp PRE-CREATION 
>   shell/tests/CMakeLists.txt PRE-CREATION 
>   shell/tests/plasma/shells/org.kde.plasmashelltest/contents/layout.js.in PRE-CREATION 
>   shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml PRE-CREATION 
>   shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127346/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160311/1c43f3ba/attachment.html>