Review Request 127342: IconItem: Schedule pixmap update when window changes
Marco Martin
notmart at gmail.com
Fri Mar 11 22:16:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127342/#review93424
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On March 11, 2016, 3:12 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127342/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 3:12 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> QQuickItem::polish is not called when window changes.
>
> Regression from 344d04e2306ca2fdaf17269bc218f4fad065cbbf
>
>
> Diffs
> -----
>
> autotests/iconitemtest.h 99ecc6c
> autotests/iconitemtest.cpp 026dda4
> src/declarativeimports/core/iconitem.cpp e199561
>
> Diff: https://git.reviewboard.kde.org/r/127342/diff/
>
>
> Testing
> -------
>
> Add show activity manager applet -> remove -> undo -> icon is now correctly rendered.
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160311/0184245f/attachment-0001.html>
More information about the Plasma-devel
mailing list