Review Request 127340: Applet: Stop deleteNotificationTimer when undo is triggered

Anthony Fieroni bvbfan at abv.bg
Fri Mar 11 15:07:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127340/#review93416
-----------------------------------------------------------



Same as https://git.reviewboard.kde.org/r/127318/
Bug is in KNotification -> https://git.reviewboard.kde.org/r/127326/

- Anthony Fieroni


On Март 11, 2016, 4:40 след обяд, David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127340/
> -----------------------------------------------------------
> 
> (Updated Март 11, 2016, 4:40 след обяд)
> 
> 
> Review request for Plasma and Anthony Fieroni.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> deleteNotificationTimer needs to be stopped when undo remove applet is trigger, otherwise the applet will be removed on deleteNotificationTimer timeout (1 min).
> 
> Regression from 6bb02c88ebece5c732bbacd861002bd00999d3bc
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/applet_p.cpp 14b1deb 
> 
> Diff: https://git.reviewboard.kde.org/r/127340/diff/
> 
> 
> Testing
> -------
> 
> Add widget -> remove widget -> undo -> wait 60 s -> applet no longer disappears by itself
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160311/3243d12e/attachment-0001.html>


More information about the Plasma-devel mailing list