Review Request 127302: IconItem: Animate active and enabled change even with animations disabled

David Rosca nowrep at gmail.com
Fri Mar 11 13:19:12 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127302/
-----------------------------------------------------------

(Updated March 11, 2016, 1:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 46a1181587c3d26c42caeec7281862753ec3f9b5 by David Rosca to branch master.


Repository: plasma-framework


Description
-------

`animated: false` should disable just animation when changing source, we still want the hover and enabled animations.
Also fix docs.


Diffs
-----

  autotests/iconitemtest.h c7ba89f 
  autotests/iconitemtest.cpp ae825a9 
  src/declarativeimports/core/iconitem.h 9613354 
  src/declarativeimports/core/iconitem.cpp 6c23a7e 

Diff: https://git.reviewboard.kde.org/r/127302/diff/


Testing
-------

Tests pass.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160311/dafc4ae3/attachment.html>


More information about the Plasma-devel mailing list