Review Request 127332: [Pager] List minimized windows in the tooltip

Marco Martin notmart at gmail.com
Fri Mar 11 09:57:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127332/#review93411
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On March 10, 2016, 5:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127332/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 5:09 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 357545
>     https://bugs.kde.org/show_bug.cgi?id=357545
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The tooltip now shows minimized windows in a separate list below the regular ones.
> 
> Drive-by changes:
> - Don't bother creating the window rectangles if the pager is hidden (ie. just one virtual desktop), saves some CPU cycles - will backport to 5.6
> - Use bindings for the colors rather than duplicating the logic
> - Use devicePixelRatio rather than 1px fixed borders
> 
> 
> Diffs
> -----
> 
>   applets/pager/package/contents/ui/main.qml eef7510 
>   applets/pager/plugin/model.h 91dabc2 
>   applets/pager/plugin/model.cpp 595e3c6 
>   applets/pager/plugin/pager.cpp de95835 
> 
> Diff: https://git.reviewboard.kde.org/r/127332/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160310_174757.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/10/12e721b4-cbcc-4da2-9268-580a0acfa14e__Screenshot_20160310_174757.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160311/dd39b7e7/attachment.html>


More information about the Plasma-devel mailing list