Review Request 125755: Fix build with QT5.6

David Kahles david.kahles96 at gmail.com
Fri Mar 11 01:35:38 UTC 2016



> On Oct. 22, 2015, 1:38 p.m., Martin Gräßlin wrote:
> > src/CMakeLists.txt, line 7
> > <https://git.reviewboard.kde.org/r/125755/diff/1/?file=412366#file412366line7>
> >
> >     is KWindowSystem being found at all in sddm-kcm?

Sorry for the late reply, I was very busy over the last moths.
I just noticed that the build works fine again with an up-to-date qt build. I don't remember the exact problem, but if it works fine now, i think this isn't needed anymore.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125755/#review87258
-----------------------------------------------------------


On Oct. 22, 2015, 1:20 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125755/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 1:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> -------
> 
> Since QT5.6, qpixmap.h pulls in qtextstream.h. Xlib.h has a
> but qtextstream.h uses Status as an enum name. fixx11h.h resolves this
> name clash.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c 
>   src/cursortheme/xcursortheme.cpp 4fc70a605d5fc3165de78916db92c13bb67c0429 
> 
> Diff: https://git.reviewboard.kde.org/r/125755/diff/
> 
> 
> Testing
> -------
> 
> Compiles now.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160311/434e21f4/attachment.html>


More information about the Plasma-devel mailing list