Review Request 127333: KCMshell window has no reason to be modal

Marco Martin notmart at gmail.com
Thu Mar 10 17:36:49 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127333/#review93393
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On March 10, 2016, 5:28 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127333/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 5:28 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> The fact that the KCMshell window is marked as modal breaks KCMs that
> want to show a non-parrented non-modal dialog - it can never get focus.
> 
> Was there a reason for making it modal?
> 
> 
> Diffs
> -----
> 
>   kcmshell/main.cpp c05ae83 
> 
> Diff: https://git.reviewboard.kde.org/r/127333/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160310/009572ba/attachment.html>


More information about the Plasma-devel mailing list