Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Mar 10 10:48:59 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/
-----------------------------------------------------------
(Updated March 10, 2016, 11:48 a.m.)
Review request for Plasma.
Changes
-------
Address David's concerns and few other things.
More work TBD.
Repository: plasma-workspace
Description
-------
Now that everything's in place in Qt, we can do that.
It basically removes all the translation layer between KScreen and QScreen.
NOTE: This can't be merged until Qt 5.6 is a dependency.
Diffs (updated)
-----
CMakeLists.txt d407aed
shell/CMakeLists.txt 7be2cfd
shell/panelview.h c671f14
shell/panelview.cpp c8c3c71
shell/shellcorona.h b803239
shell/shellcorona.cpp 54667da
Diff: https://git.reviewboard.kde.org/r/125451/diff/
Testing
-------
Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D)
File Attachments (updated)
----------------
org.kde.konversation.desktop
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/01/47534796-9ab4-4f8f-b770-089cae126b84__org.kde.konversation.desktop
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160310/65778a7a/attachment.html>
More information about the Plasma-devel
mailing list