Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127319/#review93374
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On March 9, 2016, 8:12 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127319/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 8:12 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Possible root of the error was that accidentally disconnecting not with the old, but the new source id from the dataengine before connecting with the new source id was resulting in some bogus state. Not really investigated in detail after seeing the mistake.
> 
> The patch reworks things by no longer setting the config one-by-one via properties before then signalling configchanged, but by passing the set of changed config values as separate data to store them in the KConfig object, then triggering the applet to reset with its old work values before then loading the new config values and starting to use those. That way on disconnecting we still have the old source id available now and properly disconnect.
> 
> So hopefully the occasional empty widget after setting a weather station should be gone now.
> 
> 
> Diffs
> -----
> 
>   applets/weather/package/contents/ui/configGeneral.qml a5966cd 
>   applets/weather/weatherapplet.h e37006a 
>   applets/weather/weatherapplet.cpp 957f17d 
>   libs/plasmaweather/weatherpopupapplet.h 65c8edb 
>   libs/plasmaweather/weatherpopupapplet.cpp 960ca60 
> 
> Diff: https://git.reviewboard.kde.org/r/127319/diff/
> 
> 
> Testing
> -------
> 
> 10/10 times configuring a new weather station (also from different services) worked & did not result in an empty widget (but then before I also only seldomly saw that).
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160309/dbaa1110/attachment.html>