Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127285/
-----------------------------------------------------------

(Updated March 9, 2016, 7:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Aleix Pol Gonzalez.


Changes
-------

Submitted with commit 70326bdbed9b3e2f74990e170cb400f1e6769c8d by Weng Xuetian to branch Plasma/5.6.


Repository: plasma-workspace


Description
-------

Not sure if this is an intented upstream change (I reported it anyway https://bugreports.qt.io/browse/QTBUG-51683 ), but QDBusServiceWatcher can't watch all service anymore in Qt 5.6 RC with empty service name string.

Let's simple use the "deprecated" QDBusConnectionInterface::serviceOwnerChanged signal to do this work, which is also used by qdbusviewer.

Change mpris2 dataengine and systemtray to use QDBusConnectionInterface::serviceOwnerChanged.


Diffs
-----

  applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h 9e59501 
  applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 94c3efc 
  dataengines/mpris2/mpris2engine.cpp 064ca60 

Diff: https://git.reviewboard.kde.org/r/127285/diff/


Testing
-------

mpris2 dataengine and mediacontroller now back to work with qt 5.6.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160309/845c2f40/attachment.html>