Review Request 127318: [Applet] Actually delete applet when undo times out
Anthony Fieroni
bvbfan at abv.bg
Wed Mar 9 18:19:28 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127318/#review93354
-----------------------------------------------------------
src/plasma/private/applet_p.cpp (line 325)
<https://git.reviewboard.kde.org/r/127318/#comment63656>
About me, since i made this patch, when notification is closed lambda above is called with transient = true =>
line 305, 306 as same as below lines.
- Anthony Fieroni
On Март 9, 2016, 7:48 след обяд, Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127318/
> -----------------------------------------------------------
>
> (Updated Март 9, 2016, 7:48 след обяд)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> When the undo timer fires the undo notification is removed but the applet isn't actually removed and re-appears after you restart plasma.
>
>
> Diffs
> -----
>
> src/plasma/private/applet_p.cpp 14b1deb
>
> Diff: https://git.reviewboard.kde.org/r/127318/diff/
>
>
> Testing
> -------
>
> Removed applet, pressed X on notification, restarted plasma -> applet permanently gone
> Removed applet, pressed "Undo" -> applet re-appeared
> Removed applet, waited 60s, restarted plasma -> applet permanently gone
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160309/ab772e99/attachment.html>
More information about the Plasma-devel
mailing list