Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

[Kai Uwe Broulik]

> On März 9, 2016, 4:56 nachm., Marco Martin wrote:
> > the patch is fine, but it's the one about not using unneeded loadPixmp, not the one about not animating when hidden?

yeah disregard the unittest, sorry, just need to remove the qexpectfail


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review93347
-----------------------------------------------------------


On März 9, 2016, 4:39 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> -----------------------------------------------------------
> 
> (Updated März 9, 2016, 4:39 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We have a lot of reusable singletons that are just hidden when unneeded (tooltip, osd). IconItem, however, will always fade from the previous state, even if the previous action happened minutes ago.
> 
> This patch makes it track its visibility and skip the fade-and-wait dance when it just became visible. It also removes a visible false call in the tooltip which I didn't know what it was for. (With it in place, the IconItem always becomes visible when moving between tooltip areas, breaking the animation altogether).
> 
> @Eike: Could you check whether this makes it more viable for Kicker?
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.h c7ba89f 
>   autotests/iconitemtest.cpp ae825a9 
>   src/declarativeimports/core/iconitem.h 9613354 
>   src/declarativeimports/core/iconitem.cpp 6c23a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
> 
> 
> Testing
> -------
> 
> Moving between tray icons - icon fades, moving reaaaally rapidly causes it not to load any icon until you halt (dunno if that happened before but doesn't seem too bad)
> Hovering tray icon, leaving, waiting, hovering another one - icon does not fade, is there right away
> Notifications also don't fade from the previously issued notification icon
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160309/60378c84/attachment-0001.html>