Review Request 127306: Touchpad KCM: Fix synaptics driver issues

[Rajeesh K V]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127306/
-----------------------------------------------------------

(Updated March 8, 2016, 9:11 p.m.)


Review request for Plasma, David Edmundson and Xuetian Weng.


Changes
-------

Update max value to 1000 (as supported by synaptic driver); drop message string changes.


Bugs: 359460
    https://bugs.kde.org/show_bug.cgi?id=359460


Repository: plasma-desktop


Description (updated)
-------

Fixes few things:
1.  Remove redefined members of parent class XlibTouchpad from SynapticsTouchpad class fixing wrong scroll delta values.
2.  Enlarge vertical,horizontal&circular scroll delta and maxtapmove allowing value more than 100. The max value supported by driver is 1000.

I would like to get this fix in 5.6 final.


Diffs (updated)
-----

  kcms/touchpad/src/backends/x11/synapticstouchpad.h de75125 
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp 1e01894 
  kcms/touchpad/src/kcm/touchpad.kcfg d4d127c 
  kcms/touchpad/src/kcm/ui/scroll.ui d1c2f76 
  kcms/touchpad/src/kcm/ui/tap.ui 389db5e 

Diff: https://git.reviewboard.kde.org/r/127306/diff/


Testing (updated)
-------

Built the RPM, compile tested and locally tested. Bug reporters confirm patch fixes the issue.


Thanks,

Rajeesh K V

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160308/f1ff1b85/attachment.html>