Review Request 127302: IconItem: Animate active change even with animations disabled

[David Rosca]

> On March 8, 2016, 4:19 p.m., Kai Uwe Broulik wrote:
> > What about the enabled property where it grays-out the icon if disabled?

The same should be done also for enabled property. I'll update the patch.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127302/#review93303
-----------------------------------------------------------


On March 7, 2016, 11:37 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127302/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> `animated: false` should disable just animation when changing source, we still want the hover animation.
> Also fix docs.
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.h c7ba89f 
>   autotests/iconitemtest.cpp ae825a9 
>   src/declarativeimports/core/iconitem.h 9613354 
>   src/declarativeimports/core/iconitem.cpp 6c23a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/127302/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160308/5ea78533/attachment-0001.html>