Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

Sebastian Kügler sebas at kde.org
Tue Mar 8 10:15:38 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127296/#review93289
-----------------------------------------------------------




CMakeLists.txt (line 14)
<https://git.reviewboard.kde.org/r/127296/#comment63615>

    Pardon my ignrance, but what does this mean?


- Sebastian Kügler


On March 6, 2016, 5:21 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127296/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 5:21 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: breeze-plymouth
> 
> 
> Description
> -------
> 
> KDECompilerSettings aren't included so this wasn't spotted earlier, but we pass the flag anyway in openSUSE's %cmake_kf5 macro.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3a4cd73 
>   breeze-text/CMakeLists.txt 17501cb 
> 
> Diff: https://git.reviewboard.kde.org/r/127296/diff/
> 
> 
> Testing
> -------
> 
> Now builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160308/7fbbe94a/attachment.html>


More information about the Plasma-devel mailing list